feat: 优化步骤 5 提交逻辑，点击后立即上报完成状态，避免等待页面结果

2026-04-17 03:39:22 +08:00
parent 17bbfc6394
commit ce0fe101a3
7 changed files with 307 additions and 75 deletions
@@ -0,0 +1,52 @@
+const test = require('node:test');
+const assert = require('node:assert/strict');
+const fs = require('node:fs');
+
+const source = fs.readFileSync('background/steps/fill-profile.js', 'utf8');
+const globalScope = {};
+const api = new Function('self', `${source}; return self.MultiPageBackgroundStep5;`)(globalScope);
+
+test('step 5 transport error returns immediately after completion signal arrives', async () => {
+  const events = {
+    redirectWaitCalls: 0,
+    onboardingCalls: 0,
+    logs: [],
+  };
+
+  const transportError = new Error('The message port closed before a response was received.');
+
+  const executor = api.createStep5Executor({
+    addLog: async (message, level) => {
+      events.logs.push({ message, level: level || 'info' });
+    },
+    generateRandomBirthday: () => ({ year: 2003, month: 6, day: 19 }),
+    generateRandomName: () => ({ firstName: 'Test', lastName: 'User' }),
+    getState: async () => ({
+      stepStatuses: {
+        5: 'completed',
+      },
+    }),
+    getTabId: async () => 123,
+    handleChatgptOnboardingSkip: async () => {
+      events.onboardingCalls += 1;
+    },
+    isRetryableContentScriptTransportError: (error) => error === transportError,
+    LOG_PREFIX: '[test]',
+    sendToContentScript: async () => {
+      throw transportError;
+    },
+    waitForStep5ChatgptRedirect: async () => {
+      events.redirectWaitCalls += 1;
+      return { id: 123, url: 'https://chatgpt.com/' };
+    },
+  });
+
+  await executor.executeStep5();
+
+  assert.equal(events.redirectWaitCalls, 0, '收到完成信号后不应再等待 ChatGPT 跳转');
+  assert.equal(events.onboardingCalls, 0, '收到完成信号后不应再触发 onboarding 跳过');
+  assert.ok(
+    events.logs.some(({ message }) => /已收到完成信号，直接结束当前步骤/.test(message)),
+    '应记录 Step 5 已按完成信号直接结束'
+  );
+});
@@ -0,0 +1,217 @@
+const test = require('node:test');
+const assert = require('node:assert/strict');
+const fs = require('node:fs');
+
+const source = fs.readFileSync('content/signup-page.js', 'utf8');
+
+function extractFunction(name) {
+  const markers = [`async function ${name}(`, `function ${name}(`];
+  const start = markers
+    .map((marker) => source.indexOf(marker))
+    .find((index) => index >= 0);
+  if (start < 0) {
+    throw new Error(`missing function ${name}`);
+  }
+
+  let parenDepth = 0;
+  let signatureEnded = false;
+  let braceStart = -1;
+  for (let i = start; i < source.length; i += 1) {
+    const ch = source[i];
+    if (ch === '(') {
+      parenDepth += 1;
+    } else if (ch === ')') {
+      parenDepth -= 1;
+      if (parenDepth === 0) {
+        signatureEnded = true;
+      }
+    } else if (ch === '{' && signatureEnded) {
+      braceStart = i;
+      break;
+    }
+  }
+  if (braceStart < 0) {
+    throw new Error(`missing body for function ${name}`);
+  }
+
+  let depth = 0;
+  let end = braceStart;
+  for (; end < source.length; end += 1) {
+    const ch = source[end];
+    if (ch === '{') depth += 1;
+    if (ch === '}') {
+      depth -= 1;
+      if (depth === 0) {
+        end += 1;
+        break;
+      }
+    }
+  }
+
+  return source.slice(start, end);
+}
+
+test('step 5 clicks submit and completes immediately on birthday page', async () => {
+  const step5Source = extractFunction('step5_fillNameBirthday');
+  assert.ok(
+    !step5Source.includes('waitForStep5SubmitOutcome('),
+    'Step 5 提交后不应再等待页面结果'
+  );
+
+  const api = new Function(`
+const logs = [];
+const completions = [];
+const clicks = [];
+const selectedBirthday = {};
+
+const nameInput = { value: '', hidden: false };
+const hiddenBirthday = {
+  value: '',
+  hidden: false,
+  dispatchEvent() {},
+};
+const completeButton = {
+  tagName: 'BUTTON',
+  textContent: '完成帐户创建',
+  hidden: false,
+};
+
+const birthdaySelects = {
+  '年': { label: '年', button: { hidden: false }, nativeSelect: {} },
+  '月': { label: '月', button: { hidden: false }, nativeSelect: {} },
+  '天': { label: '天', button: { hidden: false }, nativeSelect: {} },
+};
+
+const document = {
+  querySelector(selector) {
+    switch (selector) {
+      case '[role="spinbutton"][data-type="year"]':
+      case '[role="spinbutton"][data-type="month"]':
+      case '[role="spinbutton"][data-type="day"]':
+      case 'input[name="age"]':
+        return null;
+      case 'input[name="birthday"]':
+        return hiddenBirthday;
+      case 'button[type="submit"]':
+        return completeButton;
+      default:
+        return null;
+    }
+  },
+  querySelectorAll(selector) {
+    if (selector === 'input[name="allCheckboxes"][type="checkbox"]') {
+      return [];
+    }
+    return [];
+  },
+  execCommand() {},
+};
+
+const location = {
+  href: 'https://auth.openai.com/u/signup/profile',
+};
+
+function Event(type, init = {}) {
+  this.type = type;
+  this.bubbles = Boolean(init.bubbles);
+}
+
+function log(message, level = 'info') {
+  logs.push({ message, level });
+}
+
+async function waitForElement() {
+  return nameInput;
+}
+
+async function humanPause() {}
+async function sleep() {}
+
+function fillInput(input, value) {
+  input.value = value;
+}
+
+function findBirthdayReactAriaSelect(label) {
+  return birthdaySelects[label] || null;
+}
+
+function isVisibleElement(el) {
+  return Boolean(el) && !el.hidden;
+}
+
+async function setReactAriaBirthdaySelect(select, value) {
+  selectedBirthday[select.label] = String(value).padStart(select.label === '年' ? 4 : 2, '0');
+  if (selectedBirthday['年'] && selectedBirthday['月'] && selectedBirthday['天']) {
+    hiddenBirthday.value = \`\${selectedBirthday['年']}-\${selectedBirthday['月']}-\${selectedBirthday['天']}\`;
+  }
+}
+
+async function waitForElementByText() {
+  throw new Error('waitForElementByText should not run in this test');
+}
+
+function simulateClick(el) {
+  clicks.push(el.textContent || el.tagName || 'element');
+}
+
+function reportComplete(step, payload) {
+  completions.push({ step, payload });
+}
+
+function normalizeInlineText(text) {
+  return text;
+}
+
+${extractFunction('getStep5DirectCompletionPayload')}
+${extractFunction('step5_fillNameBirthday')}
+
+return {
+  async run(payload) {
+    return step5_fillNameBirthday(payload);
+  },
+  snapshot() {
+    return {
+      logs,
+      completions,
+      clicks,
+      nameValue: nameInput.value,
+      birthdayValue: hiddenBirthday.value,
+    };
+  },
+};
+`)();
+
+  const result = await api.run({
+    firstName: 'Test',
+    lastName: 'User',
+    year: 2003,
+    month: 6,
+    day: 19,
+  });
+
+  const snapshot = api.snapshot();
+  assert.deepStrictEqual(
+    result,
+    {
+      skippedPostSubmitCheck: true,
+      directProceedToStep6: true,
+    },
+    '生日模式点击提交后应直接返回完成载荷'
+  );
+  assert.deepStrictEqual(snapshot.completions, [
+    {
+      step: 5,
+      payload: {
+        skippedPostSubmitCheck: true,
+        directProceedToStep6: true,
+      },
+    },
+  ]);
+  assert.deepStrictEqual(snapshot.clicks, ['完成帐户创建']);
+  assert.equal(snapshot.nameValue, 'Test User');
+  assert.equal(snapshot.birthdayValue, '2003-06-19');
+  assert.ok(
+    snapshot.logs.some(({ message }) => /不再等待页面结果/.test(message)),
+    '日志应明确说明 Step 5 已直接完成'
+  );
+});