chickliu/ha_xiaomi_home
1
0
Fork 0
mirror of https://github.com/XiaoMi/ha_xiaomi_home.git synced 2026-01-15 05:50:43 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat: add the numerical relationship of the current position and the target position as a backup condition for is_closing and is_opening

Browse Source
This commit is contained in:
LiShuzhen 2025-01-26 16:37:26 +08:00
parent f157f24bc7
commit 3675860526
1 changed files with 28 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
custom_components/xiaomi_home/cover.py
View File

@ -232,27 +232,41 @@ class Cover(MIoTServiceEntity, CoverEntity):
@property
def is_opening(self) -> Optional[bool]:
"""Return if the cover is opening."""
if self._prop_status is None:
return None
return self.get_prop_value(
prop=self._prop_status) == self._prop_status_opening
if self._prop_status and self._prop_status_opening is not None:
return self.get_prop_value(
prop=self._prop_status) == self._prop_status_opening
# The status is prior to the numerical relationship of the current
# position and the target position when determining whether the cover
# is opening.
if (self._prop_target_position and
self.current_cover_position is not None):
return (self.current_cover_position
< self.get_prop_value(prop=self._prop_target_position))
return None
@property
def is_closing(self) -> Optional[bool]:
"""Return if the cover is closing."""
if self._prop_status is None:
return None
return self.get_prop_value(
prop=self._prop_status) == self._prop_status_closing
if self._prop_status and self._prop_status_closing is not None:
return self.get_prop_value(
prop=self._prop_status) == self._prop_status_closing
# The status is prior to the numerical relationship of the current
# position and the target position when determining whether the cover
# is closing.
if (self._prop_target_position and
self.current_cover_position is not None):
return (self.current_cover_position
> self.get_prop_value(prop=self._prop_target_position))
return None
@property
def is_closed(self) -> Optional[bool]:
"""Return if the cover is closed."""
if self._prop_current_position:
return self.get_prop_value(prop=self._prop_current_position) == 0
if self.current_cover_position is not None:
return self.current_cover_position == 0
# The current position is prior to the status when determining
# whether the cover is closed.
return (self.get_prop_value(
prop=self._prop_status) == self._prop_status_closed) if (
self._prop_status
and self._prop_status_closed is not None) else None
if self._prop_status and self._prop_status_closed is not None:
return (self.get_prop_value(
prop=self._prop_status) == self._prop_status_closed)
return None